Conversation
mcop1
approved these changes
Nov 26, 2025
…ulted in (de)serialization
…-all-assets-fails-with-a-lot-of-items' into 1539-execution-engine-batch-edit-all-assets-fails-with-a-lot-of-items
Contributor
Author
|
Waiting for FE adjustments and can be merged after |
…ails-with-a-lot-of-items # Conflicts: # src/Asset/ExecutionEngine/AutomationAction/Messenger/Handler/ExportDataCollectionHandler.php # src/Asset/ExecutionEngine/AutomationAction/Messenger/Handler/ExportFolderDataCollectionHandler.php # src/DataObject/ExecutionEngine/AutomationAction/Messenger/Handler/ExportDataCollectionHandler.php # src/DataObject/ExecutionEngine/AutomationAction/Messenger/Handler/ExportFolderDataCollectionHandler.php # src/Grid/Service/GridService.php # src/Grid/Service/GridServiceInterface.php
…ails-with-a-lot-of-items # Conflicts: # src/Asset/ExecutionEngine/AutomationAction/Messenger/Handler/ExportDataCollectionHandler.php # src/Asset/ExecutionEngine/AutomationAction/Messenger/Handler/ExportFolderDataCollectionHandler.php # src/DataObject/ExecutionEngine/AutomationAction/Messenger/Handler/ExportDataCollectionHandler.php # src/DataObject/ExecutionEngine/AutomationAction/Messenger/Handler/ExportFolderDataCollectionHandler.php # src/Element/ExecutionEngine/AutomationAction/Messenger/Handler/ElementUsageReplaceHandler.php # src/Element/ExecutionEngine/AutomationAction/Messenger/Handler/PatchFolderHandler.php
…ails-with-a-lot-of-items
23 tasks
Not up to standards ⛔
|
…ne-batch-edit-all-assets-fails-with-a-lot-of-items
|
lukmzig
deleted the
1539-execution-engine-batch-edit-all-assets-fails-with-a-lot-of-items
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #1539
Additional info
Batch patch endpoints were adapted so they process each item in a separate instance of a step.
Relevant endpoints were changed as well, they accept only 1 folder per request and the
folder idparameter was moved to the path.Affected endpoints:
/pimcore-studio/api/assets/folder=>/pimcore-studio/api/assets/folder/{id}/pimcore-studio/api/data-objects/folder=>/pimcore-studio/api/data-objects/folder/{id}Export endpoints were changed similarly as well. However, we had to find a different approach here as the processing of the items has to be done sequentially to preserve the order of the exported elements. Because of this, we had to split the batch export (folder export) for both XLSX and CSV into 2 jobs.
Important change here is, that the initial job has a
jobRunChildIdwhich then collects all data in separate steps and creates an export file. For downloading the export file you need to therefore passjobRunChildIdand NOT original jobRunId!Relevant endpoints were changed as well, they accept only 1 folder per request and the
folder idparameter was moved to the path.Affected endpoints:
/pimcore-studio/api/export/csv/folder=>/pimcore-studio/api/export/csv/folder/{id}/pimcore-studio/api/export/xlsx/folder=>/pimcore-studio/api/export/xlsx/folder/{id}Furthermore,
classIdwas added as a required parameter for selected elements exports, when exportingdata-objectelements. This was already the case forfolder exportsAffected endpoints:
/pimcore-studio/api/export/csv/pimcore-studio/api/export/xlsx